Add BITCODE_GENERATION_MODE = bitcode for iOS builds #1698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though `-fembed-bitcode` is specified and the binaries have `__LLVM` segments for bitcode, Xcode fails when building an app with bitcode enabled. Adding this option to iOS builds alongside the `-fembed-bitcode` flags eliminates this error and Xcode does not fail upon not finding bitcode in FBSDKLoginKit.framework.
ide
requested review from
jingping2015,
joesus,
kalendae and
robtimp
as code owners
|
We just hit this, would love some eyes on this. |
|
@joesus has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Even though
-fembed-bitcodeis specified and the binaries have__LLVMsegments for bitcode, Xcode fails when building an app with bitcode enabled.Adding this option to iOS builds alongside the
-fembed-bitcodeflags eliminates this error and Xcode does not fail upon not finding bitcode in FBSDKLoginKit.framework.See #1679.
Test Plan
Test Plan: Ran
scripts/run.sh release github static, unzipped the built FBSDKLoginKit framework, manually copied the FBSDKLoginKit binary into the Pods folder of an app that depends on the FacebookSDK pod, built an app archive. Previously got an error saying,After copying the newly built library binary in, this error went away (ran into other build errors but I believe they are not caused by this commit).