Do not install test requirements in distribution #578
Conversation
|
Hi @joekohlsdorf! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
@jingping2015 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Looks like tests fail but I can't see the output, can you give me a hint what the problem could be? |
Summary: Installing facebook-python-business-sdk from PyPI installs mock, a development requirement. This PR only installs development requirements when running tests. Pull Request resolved: #578 Reviewed By: joesus Differential Revision: D24452740 Pulled By: jingping2015 fbshipit-source-id: d8ba2c7a
|
This pull request has been merged in 6b5ca67. |
Installing facebook-python-business-sdk from PyPI installs mock, a development requirement.
This PR only installs development requirements when running tests.