Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated UploadIO constant #204

Closed
wants to merge 2 commits into from
Closed

Replace deprecated UploadIO constant #204

wants to merge 2 commits into from

Conversation

thomasmarshall
Copy link
Contributor

This constant was deprecated in multipart-post v2.2.0 1 but faraday-multipart v1.0.4 introduced a workaround to avoid the deprecated constant warning 2. This commit switches out UploadIO references to use the Faraday namespaced one.

This constant was deprecated in `multipart-post` v2.2.0 [1] but
`faraday-multipart` v1.0.4 introduced a workaround to avoid the
deprecated constant warning [2]. This commit switches out `UploadIO`
references to use the `Faraday` namespaced one.

[1]: socketry/multipart-post@cb18a32
[2]: lostisland/faraday-multipart@2127a0c
@facebook-github-bot
Copy link

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@stcheng
Copy link
Contributor

stcheng commented Jan 20, 2024

This PR will address #206

facebook-github-bot pushed a commit to facebook/facebook-business-sdk-codegen that referenced this pull request Jan 22, 2024
Summary:
This constant was deprecated in `multipart-post` v2.2.0 [1] but `faraday-multipart` v1.0.4 introduced a workaround to avoid the deprecated constant warning [2]. This commit switches out `UploadIO` references to use the `Faraday` namespaced one.

[1]: socketry/multipart-post@cb18a32
[2]: lostisland/faraday-multipart@2127a0c

X-link: facebook/facebook-ruby-business-sdk#204

Reviewed By: mengxuanzhangz

Differential Revision: D52926662

Pulled By: stcheng

fbshipit-source-id: b999d59c992b0351924bdfb10d33ab34de788c69
@facebook-github-bot
Copy link

@stcheng merged this pull request in 290d57e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants