Allow faraday configuration #205
Conversation
|
Hi @egenny! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
egenny
force-pushed
the
add-connection-setup
branch
2 times, most recently
from
2a63828
to
7a4d255
Compare
Allow the constructor to accept a block and store it in
an instance variable as a proc for configuring Faraday.
The block allows the inclusion of Faraday Middleware, for example:
FacebookAds::Session.new(
access_token: "a_token",
app_secret: "a_secret
) { |faraday| faraday.response :my_faraday_middleware }
egenny
force-pushed
the
add-connection-setup
branch
from
7a4d255
to
8ad95d1
Compare
execute will use the passed in session if available
or create a session from the access_token if no
session is available.
This allows Faraday middleware to be used by EventRequest.
session = FacebookAds::Session.new(access_token: token) { |faraday| faraday.response :some_faraday_middleware }
FacebookAds::ServerSide::EventRequestAsync.new(
pixel_id: pixel_id,
events: [event],
session: session,
)
Allow the constructor to accept a block and store it in an instance variable for use by the request method.
The block allows the inclusion of Faraday Middleware.