Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port dev engines script from React #48

Merged
merged 1 commit into from
Aug 31, 2015
Merged

Conversation

zpao
Copy link
Member

@zpao zpao commented Aug 31, 2015

This brings in the script that we're using in React to make sure the dev environment is what we expect. It's slightly modified to require a file argument since we can't hardcode the path to the package.json that we want to use. Specifically it checks devEngines in package.json, which is something I made up (but correlates nicely with the engines field that npm sort of uses)

I confirmed this is working in React with

"scripts": {
  "preinstall": "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json"
}

@zpao zpao mentioned this pull request Aug 31, 2015
zpao added a commit that referenced this pull request Aug 31, 2015
Port dev engines script from React
@zpao zpao merged commit 8568bfd into facebook:master Aug 31, 2015
@zpao zpao deleted the dev-env-script branch November 17, 2015 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants