New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save previous pointer automatically #18
Conversation
Removes the need to do so manually via dlsym calls.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I like this, but it does change the API for existing users. What's the motivation for the change? |
Besides the two reasons on the first comment, it was done to have a similar hooking interface as other projects like cydiasubstrate's |
Sounds good. I'm okay with breaking compatibility since fishhook is mostly for debugging anyway. :) |
Save previous pointer automatically
Thanks! |
No problem! |
🍰 |
The current podspec with the tag pointing to release 0.1 does not include this change. Could we have the podspec point to master or create a new release 0.2 with this change? |
Removes the need to do so manually via dlsym calls. Also allows having multiple hooks on the same symbol.