Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fishhook Podspec to refer to the latest API-Changing Commit instead of Release 0.1. #22

Closed
wants to merge 1 commit into from

Conversation

tirodkar
Copy link
Contributor

@tirodkar tirodkar commented Jan 5, 2016

Related Issue : #20

When the pull request - #18 was merged, it broke the API for anyone using fishhook with CocoaPods since the repo at HEAD has a different interface from the Pods Sources.

In the Podspec, we are currently using the release version of fishhook. However, creating releases can be extremely tedious, especially with the case of a single maintainer and it would be much better if we could simply point to a specific commit.

@tirodkar
Copy link
Contributor Author

@grp, just checking if you had any updates on this Pull Request.

@grp
Copy link
Contributor

grp commented Jan 11, 2016

Hi, I'd prefer to keep this as is for now. In general I suggest tracking master rather than a specific release commit.

@grp grp closed this Jan 11, 2016
@tirodkar
Copy link
Contributor Author

Considering that master has been updated, I'd suggest you should update the Podspec and releases as well. Now we have an older version of fishhook being obtained by CocoaPods than by cloning from Github.

@tirodkar
Copy link
Contributor Author

@grp, we use fishhook for our internal project that is being used by multiple teams. It is highly cumbersome to have all their Podfiles point to head. Would you prefer it if we changed the Podspec to point to master instead of the commit here? We would really appreciate any help you could provide us here.

@grp
Copy link
Contributor

grp commented Jan 12, 2016

Hey, sorry about that. I'll see if I can do a normal CocoaPods release today.

@tirodkar
Copy link
Contributor Author

That would be great! Thank you very much.

@tirodkar
Copy link
Contributor Author

Hey @grp, just checking if you had an ETA for the update by any chance.

@grp
Copy link
Contributor

grp commented Jan 20, 2016

Sorry about that (again) — I just pushed 0.2 to master and to CocoaPods trunk.

@tirodkar
Copy link
Contributor Author

Thanks a ton for the update @grp, really appreciate it.

@jobsyu jobsyu mentioned this pull request Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants