Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for AndroidX fragments (#957)
Summary: Fix #931 This is not how I would *like* to fix this, but it should do the job. When the switch over to AndroidX was made, the overall abstraction started to leak and we really need to remodel this in its entirety. There's also the question of whether we want to support both support fragments and AndroidX fragments or not. Right now it's kinda-sorta supported but only under some circumstances, which is not great. I also added some more defensive try/catches as there's some unsafe casting involved and future changes may break this causing the entire layout to disappear. Change Log: Fix support for AndroidX fragments in Layout Inspector. Pull Request resolved: #957 Test Plan: Changed the sample app to include some AndroidX fragments and they now show up (again) in the view hierarchy: ![Screenshot 2020-04-01 13 40 53](https://user-images.githubusercontent.com/9906/78138910-915fbc00-741f-11ea-8386-4eeca9b7f932.png) Tested internally that FB4A fragments show up again, too: {F233098198} Reviewed By: mweststrate Differential Revision: D20792503 Pulled By: passy fbshipit-source-id: 7030b897ab547d1e8803b7f0d7aaa34263cfaed2
- Loading branch information
1 parent
492b107
commit 4be1b4d
Showing
3 changed files
with
38 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters