Add support for AndroidX fragments #957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix #931 This is not how I would *like* to fix this, but it should do the job. When the switch over to AndroidX was made, the overall abstraction started to leak and we really need to remodel this in its entirety. There's also the question of whether we want to support both support fragments and AndroidX fragments or not. Right now it's kinda-sorta supported but only under some circumstances, which is not great. Test Plan: Changed the sample app to include some AndroidX fragments and they now show up (again) in the view hierarchy:
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
benoitdion
reviewed
Apr 1, 2020
| if (fieldMAdded != null) { | ||
| fieldMAdded.setAccessible(true); | ||
| mFieldMAdded = fieldMAdded; | ||
| if (fragmentManager instanceof android.app.FragmentManager) { |
There was a problem hiding this comment.
The instanceof check here defeats the purpose of this abstraction a bit but this looks like a working fix otherwise.
|
@passy will you also be committing the changes to the example app to help catch regressions sooner? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix #931
This is not how I would like to fix this, but it should do the job.
When the switch over to AndroidX was made, the overall abstraction
started to leak and we really need to remodel this in its entirety.
There's also the question of whether we want to support both support
fragments and AndroidX fragments or not. Right now it's kinda-sorta
supported but only under some circumstances, which is not great.
I also added some more defensive try/catches as there's some unsafe casting
involved and future changes may break this causing the entire layout to disappear.
Test Plan:
Changed the sample app to include some AndroidX fragments and they
now show up (again) in the view hierarchy:
Change Log:
Fix support for AndroidX fragments in Layout Inspector.