Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS]Update glog and doubleconversion which uses xcframework #2153

Closed
wants to merge 3 commits into from
Closed

[iOS]Update glog and doubleconversion which uses xcframework #2153

wants to merge 3 commits into from

Conversation

priteshrnandgaonkar
Copy link
Contributor

@priteshrnandgaonkar priteshrnandgaonkar commented Apr 4, 2021 •
edited
Loading

Summary

This PR updates the Glog and DoubleConversion deps. Now the deps are shipped with precompiled xcframework. It will speed up our build time a bit.
The definition can be found here for glog and here for double-conversion

There has been improvements in time. I will try to precompile folly to improve the timings significantly.

Changelog

  • Updated the Glog and DoubleConversion deps to the precompiled xcframework one
  • Updated the sample app's Podfile.lock

Test Plan

  • CI should be green
  • Verified that sample app builds.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 4, 2021
@priteshrnandgaonkar priteshrnandgaonkar changed the title update glog and doubleconversion [iOS]Update glog and doubleconversion which uses xcframework Apr 4, 2021
@coveralls
Copy link

coveralls commented Apr 4, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 717475102

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 47.818%
Totals Coverage Status
Change from base Build 708418601: 0.03%
Covered Lines: 6787
Relevant Lines: 12971
💛 - Coveralls

@priteshrnandgaonkar priteshrnandgaonkar changed the title [iOS]Update glog and doubleconversion which uses xcframework [WIP][iOS]Update glog and doubleconversion which uses xcframework Apr 4, 2021
@priteshrnandgaonkar priteshrnandgaonkar changed the title [WIP][iOS]Update glog and doubleconversion which uses xcframework [iOS]Update glog and doubleconversion which uses xcframework Apr 4, 2021
@facebook-github-bot
Copy link
Contributor

@priteshrnandgaonkar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@priteshrnandgaonkar merged this pull request in 6ba5a41.

@mikehardy mikehardy mentioned this pull request Feb 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priteshrnandgaonkar @coveralls @facebook-github-bot