Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTMLElement.focus missing options object #7651

Closed
gaastonsr opened this issue Apr 18, 2019 · 2 comments
Closed

HTMLElement.focus missing options object #7651

gaastonsr opened this issue Apr 18, 2019 · 2 comments
Labels
Accepting PRs Library definitions Issues or pull requests about core library definitions

Comments

@gaastonsr
Copy link

Missing/Incorrect APIs

The focus method of HTMLElement is missing the options object.

Relevant documentation

Typedef.
Focus docs.
@gaastonsr gaastonsr added the Library definitions Issues or pull requests about core library definitions label Apr 18, 2019
@cindyyu cindyyu mentioned this issue May 9, 2019
Closed
@cindyyu
Copy link
Contributor

cindyyu commented May 9, 2019

Hi,

I am attempting to address this issue in PR #7711 as my first contribution. 😄

Thanks,
Cindy

facebook-github-bot pushed a commit that referenced this issue May 16, 2019
@cindyyu @facebook-github-bot
[PR] HTMLElement: add options parameter for focus method
f6a49f6 
Summary:
Issue #7651: The HTMLElement focus method is missing the optional options parameter.
[MDN documentation on focusOptions parameter](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus#Syntax)

I added a new type for the focus options and added an optional parameter to the focus method on HTMLElement.

*HTMLInputElement*
I noticed that HTMLInputElement also has a focus() method on it, but I am unsure if HTMLInputElement's focus also accepts options. When I looked at the HTMLInputElement MDN docs, I was under the impression that it would also accept the same options since the focus() hyperlink directs you to the docs on HTMLElement.focus. I did not dig too much into this since I wanted to focus (😄) on a small change and understand how the contribution process works.

Please let me know if I am missing any steps or if anything is sorely incorrect... this is my first attempt at contributing. 😄
Pull Request resolved: #7711

Reviewed By: jbrown215

Differential Revision: D15320106

Pulled By: dsainati1

fbshipit-source-id: 95901fe27a76faa5ed8c8189d50e12fe674b8dac
@cindyyu
Copy link
Contributor

cindyyu commented May 18, 2019

This should be addressed by #7711.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Library definitions Issues or pull requests about core library definitions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gaastonsr @goodmind @cindyyu @jbrown215