New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support textDocument/codeLens request in LSP #7890
Comments
For context for others, is was discussed that the output in most cases might be too verbose. We could consider adding this behind some sort of configuration Flag |
we should talk through what specific code lenses we'll support. agree that the signature might be too verbose, or redundant. but there are other lenses like find-refs that seem like a good fit. |
Summary: Adds basic requests to implement facebook/flow#7890 Pull Request resolved: facebook/flow#7891 Reviewed By: gabelevi Differential Revision: D16223318 Pulled By: mroch fbshipit-source-id: 529906af5e00e4b4de31aefbd66dd7a20a9c07c7
Using CodeLens for type inference or hints might be noisy or too verbose. While that way might be useful for languages where annotations are optional (OCaml) to demonstrate value, when possible; in other languages with strong-typing (Java, C++) or encouraged-typing, like Flow here (or TypeScript's use of CodeLens in references), it'd be better to avoid the noise and save the editor-space for code. |
Proposal
Support
textDocument/codeLens
requesttextDocument/codeLens
codeLens/resolve
Use case
Support type annotations for top-level variables in codeLens like ReasonML and OCaml language servers
The text was updated successfully, but these errors were encountered: