Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some docs about %checks #5087

Closed
wants to merge 1 commit into from
Closed

Conversation

apsavin
Copy link
Contributor

@apsavin apsavin commented Oct 13, 2017

For #4723

@jcready
Copy link
Contributor

jcready commented Oct 15, 2017

You should probably also mention that these predicate functions must return immediately (i.e. you cannot declare variables) and that you cannot call other predicate functions inside a predicate function (i.e everything must be inlinined into a single predicate function).

@gabelevi
Copy link
Contributor

Our intern who built %checks, @panagosg7, just returned to FB full time! I'll run this by him and see if he's cool with some preliminary docs.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabelevi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@apsavin
Copy link
Contributor Author

apsavin commented Oct 17, 2017

@jcready thanks for the tips!
@panagosg7 fixed.

@apsavin
Copy link
Contributor Author

apsavin commented Oct 17, 2017

@panagosg7 Fixed.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panagosg7 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants