Fix haste_name_reducers on Windows #7419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Windows support for the `module.system.haste.name_reducers` option in .flowconfig, used by projects including React Native. The file paths weren't being normalized for Windows in `is_haste_file` and `haste_name` (converting `\` to `/`), so the regex was always failing. Fixes #7138
This was referenced Jan 31, 2019
|
Thanks for working on this functionality! Getting Flow running for React Native in windows is a huge accomplishment. This seems like something that can be tested with one of the e2e tests in the Flow repo that is run on Windows. Could you add a test? |
There was a problem hiding this comment.
@avikchaudhuri has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
3 tasks
gabelevi
pushed a commit
that referenced
this pull request
Feb 4, 2019
Summary: Adds Windows support for the `module.system.haste.name_reducers` option in .flowconfig, used by projects including React Native. The file paths weren't being normalized for Windows in `is_haste_file` and `haste_name` (converting `\` to `/`), so the regex was always failing. Fixes #7138 Pull Request resolved: #7419 Reviewed By: mroch Differential Revision: D13900899 Pulled By: avikchaudhuri fbshipit-source-id: c6613c862aaaafa1342dd7199b436446e99b8fd8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Windows support for the
module.system.haste.name_reducersoption in .flowconfig, used by projects including React Native.The file paths weren't being normalized for Windows in
is_haste_fileandhaste_name(converting\to/), so the regex was always failing.Fixes #7138