lib/node: Add util.TextDecoder/TextEncoder #7713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodmind
added
the
Library definitions
cakoose
force-pushed
the
nodeTextEncoderDecoder
branch
from
804c6cc
to
e17ff03
Compare
cakoose
force-pushed
the
nodeTextEncoderDecoder
branch
from
e17ff03
to
e2eccf8
Compare
There was a problem hiding this comment.
@mvitousek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@mvitousek merged this pull request in c8b557b. |
|
This is actually just duplicates same thing from |
|
Oh, interesting. I wonder if there's a way to share some of the definitions. One tricky thing is that the Node API is slightly different. For example, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library docs:
Node 8.3 added them to 'util'.
Node 11.0 added them to the global object, but I didn't do that part.