Support all options in flow init --options
#7771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @mroch |
There was a problem hiding this comment.
@mroch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
this is going to take me some time to merge because our internal build system (buck) does not like the new ppx. it would seem that ppx_fields_conv doesn't have a way to build its own ppx executable nor a self-contained deriving plugin (ppx_fields_conv.cmxs links against Base). I think we might have to build our own driver similar to ppx_jane to get this to work with buck. |
|
It's mostly for typechecking when new fields would get added |
goodmind
added
Stalled
|
Our options have changed a lot since this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7769
Doesn't support
module.name_mappers