Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [declarations] not suppressing errors correctly & rename to [silence] #8105

Closed
wants to merge 2 commits into from
Closed

Fix [declarations] not suppressing errors correctly & rename to [silence] #8105

wants to merge 2 commits into from

Commits on Oct 4, 2019

  1. fix(declarations): suppress errors after merge, not during 

    Fixes facebook#6631, facebook#6717, facebook#7803.

There are two major flaws in the original approach:

1. Silencing errors at the merge site does not work for builtins,
as those errors are computed later, and
2. Putting that suppression in an if/else where the else block
parsed comment error suppressions can cause [declarations] to
actually create *more* errors, which was misleading a lot of people
and masked the source of bugs.

We now suppress entire files in error collation, at the very end
of the error reporting process.
    @STRML
    STRML committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    e79b638 View commit details
    Browse the repository at this point in the history

  2. fix(declarations): remove unused suppression code 

    Related to the previous commit, this backs out some of the code
in facebook#4916 related to file error suppression in the merge phase.

This has the benefit of fixing erroneous ignoring of comment
suppressions within those files, which was causing unexpected
consequences.
    @STRML
    STRML committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    91ee689 View commit details
    Browse the repository at this point in the history