Skip to content

Commit

Permalink
Don't strip AnimatedFactoryImpl and AnimatedFactoryImplSupport constr…
Browse files Browse the repository at this point in the history
…uctors

Summary:
`AnimatedFactoryImpl` and `AnimatedFactoryImplSupport` currently have the `DoNotStrip` annotation.
However, ProGuard strips their constructors since they are not used directly (we use reflection to instantiate them).
By manually addin `DoNotStrip` to these constructors, we make sure that they are not stripped.

Reviewed By: massimocarli, kirwan

Differential Revision: D3458359

fbshipit-source-id: b5f020138ad82dc3225b99a55544edf939f206f2
  • Loading branch information
oprisnik authored and Facebook Github Bot committed Jun 21, 2016
1 parent 1ed36ff commit 0d0c575
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
@DoNotStrip
public class AnimatedFactoryImplSupport extends AnimatedFactoryImpl {

@DoNotStrip
public AnimatedFactoryImplSupport(
PlatformBitmapFactory platformBitmapFactory,
ExecutorSupplier executorSupplier) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public class AnimatedFactoryImpl implements AnimatedFactory {

private PlatformBitmapFactory mPlatformBitmapFactory;

@DoNotStrip
public AnimatedFactoryImpl(
PlatformBitmapFactory platformBitmapFactory,
ExecutorSupplier executorSupplier) {
Expand Down

0 comments on commit 0d0c575

Please sign in to comment.