64-bit ARM and x86_64 - updating PR #121 #176

robert-wallis · 2015-04-21T18:31:18Z

Just finishing updating PR #121 @orospakr started, by updating the files that @michalgr suggested to use Java long instead of int to store the context id.

…#121

michalgr · 2015-04-22T13:35:09Z

I'll run some tests before merging.

orospakr · 2015-04-22T18:40:03Z

Thanks, @michalgr. :)

There's definitely an issue in my original PR; if you try to use the GIF support you'll get runtime symbol lookup errors. I expect to dive into this and properly test it later today.

robert-wallis · 2015-04-24T18:36:45Z

This code produces the following stacktrace from issue #193:

04-23 20:56:16.452  25908-26161/? E/AndroidRuntime﹕ FATAL EXCEPTION: pool-2-thread-1
    Process: com.facebook.fresco.sample, PID: 25908
    java.lang.UnsatisfiedLinkError: JNI_ERR returned from JNI_OnLoad in "/data/app/com.facebook.fresco.sample-1/lib/arm64/libgifimage.so"
            at java.lang.Runtime.loadLibrary(Runtime.java:371)
            at java.lang.System.loadLibrary(System.java:989)
            at com.facebook.common.soloader.SoLoaderShim$DefaultHandler.loadLibrary(SoLoaderShim.java:34)
            at com.facebook.common.soloader.SoLoaderShim.loadLibrary(SoLoaderShim.java:56)
            at com.facebook.imagepipeline.gif.GifImage.ensure(GifImage.java:42)
            at com.facebook.imagepipeline.gif.GifImage.create(GifImage.java:64)
            at com.facebook.imagepipeline.animated.factory.AnimatedImageFactory.decodeGif(AnimatedImageFactory.java:62)
            at com.facebook.imagepipeline.decoder.ImageDecoder.decodeAnimatedGif(ImageDecoder.java:105)
            at com.facebook.imagepipeline.decoder.ImageDecoder.decodeImage(ImageDecoder.java:86)
            at com.facebook.imagepipeline.producers.DecodeProducer$ProgressiveDecoder.doDecode(DecodeProducer.java:232)
            at com.facebook.imagepipeline.producers.DecodeProducer$ProgressiveDecoder.access$200(DecodeProducer.java:92)
            at com.facebook.imagepipeline.producers.DecodeProducer$ProgressiveDecoder$3.run(DecodeProducer.java:202)
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
            at java.lang.Thread.run(Thread.java:818)

rockerhieu · 2015-04-30T11:58:20Z

I tested this PR on a Nexus 5 (Android 5.1) and the problem still happened:

E/AndroidRuntime(22014): java.lang.UnsatisfiedLinkError: JNI_ERR returned from JNI_OnLoad in "/data/app/com.facebook.fresco.sample-1/lib/arm/libgifimage.so"
E/AndroidRuntime(22014):    at java.lang.Runtime.loadLibrary(Runtime.java:371)
E/AndroidRuntime(22014):    at java.lang.System.loadLibrary(System.java:988)
E/AndroidRuntime(22014):    at com.facebook.common.soloader.SoLoaderShim$DefaultHandler.loadLibrary(SoLoaderShim.java:34)
E/AndroidRuntime(22014):    at com.facebook.common.soloader.SoLoaderShim.loadLibrary(SoLoaderShim.java:56)
E/AndroidRuntime(22014):    at com.facebook.imagepipeline.gif.GifImage.ensure(GifImage.java:40)
E/AndroidRuntime(22014):    at com.facebook.imagepipeline.gif.GifImage.create(GifImage.java:62)
E/AndroidRuntime(22014):    at com.facebook.imagepipeline.animated.factory.AnimatedImageFactory.decodeGif(AnimatedImageFactory.java:62)
E/AndroidRuntime(22014):    at com.facebook.imagepipeline.decoder.ImageDecoder.decodeAnimatedGif(ImageDecoder.java:105)
E/AndroidRuntime(22014):    at com.facebook.imagepipeline.decoder.ImageDecoder.decodeImage(ImageDecoder.java:86)
E/AndroidRuntime(22014):    at com.facebook.imagepipeline.producers.DecodeProducer$ProgressiveDecoder.doDecode(DecodeProducer.java:231)
E/AndroidRuntime(22014):    at com.facebook.imagepipeline.producers.DecodeProducer$ProgressiveDecoder.access$200(DecodeProducer.java:92)
E/AndroidRuntime(22014):    at com.facebook.imagepipeline.producers.DecodeProducer$ProgressiveDecoder$3.run(DecodeProducer.java:202)
E/AndroidRuntime(22014):    at com.facebook.common.executors.SerialDelegatingExecutor.executeSingleCommand(SerialDelegatingExecutor.java:76)
E/AndroidRuntime(22014):    at com.facebook.common.executors.SerialDelegatingExecutor.access$000(SerialDelegatingExecutor.java:24)
E/AndroidRuntime(22014):    at com.facebook.common.executors.SerialDelegatingExecutor$1.run(SerialDelegatingExecutor.java:47)
E/AndroidRuntime(22014):    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
E/AndroidRuntime(22014):    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
E/AndroidRuntime(22014):    at java.lang.Thread.run(Thread.java:818)

yosit · 2015-05-12T06:01:24Z

+1 on this

michalgr · 2015-05-13T10:01:43Z

imagepipeline/src/main/jni/gifimage/gif.cpp

@@ -865,7 +865,7 @@ jint GifImage_nativeGetSizeInBytes(JNIEnv* pEnv, jobject thiz) {
 void GifImage_nativeDispose(JNIEnv* pEnv, jobject thiz) {
  pEnv->MonitorEnter(thiz);
  GifImageNativeContext* pNativeContext =
-      (GifImageNativeContext*) pEnv->GetIntField(thiz, sGifImageFieldNativeContext);
+      (GifImageNativeContext*) pEnv->GetLongField(thiz, sGifImageFieldNativeContext);
  if (pNativeContext != nullptr) {
    pEnv->SetIntField(thiz, sGifImageFieldNativeContext, 0);


SetLongField

michalgr · 2015-05-13T10:30:40Z

Sorry for keeping you waiting, we are still waiting for 64bit device.

Fortunately the issue happens on all architectures, so I am able to repro this. There are some leftovers, new long fields are accessed as int fields. I was able to mark 4 of those places in the diff, but there are 8 more. To get all of them covered we would have to replace all occurrences of "I" (with double quotes) in webp.cpp and gif.cpp with "J" (this will tell JNI that we are looking for long fields rather than int fields), as well as "(I)V" in the same files with "(J)V" (this will tell JNI that the constructors we are looking for take long as the only argument. With those changes I am able to run this on non 64 bit device.

ashughes · 2015-05-19T15:39:02Z

Just wanted to add my +1 for this. Any update on the progress?

JackPeel · 2017-02-24T03:00:29Z

java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.yikaton.handyshop-1/base.apk"],nativeLibraryDirectories=[/data/app/com.yikaton.handyshop-1/lib/arm64, /vendor/lib64, /system/lib64]]] couldn't find "libimagepipeline.so" how to solve it? help~

JackPeel · 2017-02-24T03:02:39Z

my system is windows 64 bits

oprisnik · 2017-02-27T09:17:06Z

You have to use the correct ABIs, see http://frescolib.org/docs/multiple-apks.html

wudongjiang333 · 2017-07-31T06:41:57Z

@JackPeel i have this problem too.Did you known how to fit it ????please tell me,thx

orospakr and others added 3 commits April 9, 2015 15:59

Enable use on 64-bit ARM and x86_64 devices.

b4cad20

Use jlong instead of long.

1bc0afe

Updating java to use long instead of int for context, for PR facebook…

f79e336

…#121

facebook-github-bot added the CLA Signed label Apr 21, 2015

tyronen assigned michalgr Apr 22, 2015

michalgr added the approved label Apr 22, 2015

This was referenced Apr 24, 2015

UnsatisfiedLinkError in Sample app on x86_64 #193

Closed

UnsatisfiedLinkError NativeMemoryChunk x86_64 #192

Closed

tyronen removed the approved label Apr 25, 2015

cmelchior mentioned this pull request May 7, 2015

Fresco + Realm.io library conflicts on 64-bit devices #237

Closed

michalgr reviewed May 13, 2015
View reviewed changes

michalgr mentioned this pull request May 22, 2015

java.lang.NoClassDefFoundError: com/facebook/imagepipeline/nativecode/Bitmaps #288

Closed

michalgr added approved imported labels May 26, 2015

michalgr mentioned this pull request May 28, 2015

64-bit ARM and x86_64 architecture support (NB: not yet fully tested!) #121

Closed

tyronen closed this Jun 2, 2015

LiuXuancen mentioned this pull request Jan 28, 2021

Crash when loading gif picture #2580

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

64-bit ARM and x86_64 - updating PR #121 #176

64-bit ARM and x86_64 - updating PR #121 #176

robert-wallis commented Apr 21, 2015

michalgr commented Apr 22, 2015

orospakr commented Apr 22, 2015

robert-wallis commented Apr 24, 2015

rockerhieu commented Apr 30, 2015

yosit commented May 12, 2015

michalgr May 13, 2015

michalgr commented May 13, 2015

ashughes commented May 19, 2015

JackPeel commented Feb 24, 2017

JackPeel commented Feb 24, 2017

oprisnik commented Feb 27, 2017

wudongjiang333 commented Jul 31, 2017

64-bit ARM and x86_64 - updating PR #121 #176

64-bit ARM and x86_64 - updating PR #121 #176

Conversation

robert-wallis commented Apr 21, 2015

michalgr commented Apr 22, 2015

orospakr commented Apr 22, 2015

robert-wallis commented Apr 24, 2015

rockerhieu commented Apr 30, 2015

yosit commented May 12, 2015

michalgr May 13, 2015

Choose a reason for hiding this comment

michalgr commented May 13, 2015

ashughes commented May 19, 2015

JackPeel commented Feb 24, 2017

JackPeel commented Feb 24, 2017

oprisnik commented Feb 27, 2017

wudongjiang333 commented Jul 31, 2017