Skip to content

Commit

Permalink
Make sure MSVC++ redistributable DLLs become part of the release
Browse files Browse the repository at this point in the history
Summary:
msvcp140.dll and vcruntime140.dll were not being included in the release due to
the package.json. These are required for the Windows binaries.

Reviewed By: mhorowitz

Differential Revision: D18412036

fbshipit-source-id: d09e9f714390bdef28333c6a5047fdc5952010f6
  • Loading branch information
willholen authored and facebook-github-bot committed Nov 9, 2019
1 parent 0075135 commit aa46fee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion npm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"linux64-bin/hermes-repl",
"win64-bin/hermes.exe",
"win64-bin/hermes-repl.exe",
"win64-bin/icu*.dll"
"win64-bin/*.dll"
],
"devDependencies": {
"request": "^2.88.0",
Expand Down

0 comments on commit aa46fee

Please sign in to comment.