wrapping of global decls (like isatty) incompatible with Dinkumware headers

[matthargett]

in gtest-port.h, they wrap xplat functions such as atty like this:

inline int IsATTY(int fd) { return isatty(fd); }

in Hermes' OSCompat.h, the same name+case is used, so :: has to be applied to make the namespace explicit.

inline int isatty(int fd) {
  return ::isatty(fd);
}

The Dinkumware-based headers on my platform don't explcitly add isatty() and friends to the C++ global namespace, so they can't be accessed with the preceding ::. Removing that explciit namespace makes it a recursive function call, which isn't correct. This kind of portability issue is presumably why the gtest maintainers decided to make the wrappers a different case.

I can submit a PR for isatty(), which is the only problem I'm having thus far, that changes the wrapper name to be cased like gtest does. Just let me know what case-style to use (isATTY vs IsATTY vs isAtty vs IsAtty, etc).

[matthargett]

Found a workaround, so maybe not necessary.