-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile the Hermes debug version without asserts #73
Comments
Is there a workaround that can be applied to existing React Native projects? |
This has landed in f72b687. Will publish an NPM soon. |
@willholen any chance it will make into a build release of RN or would we have to wait for next major release? |
Regardless of which RN version will use 0.2.0 by default, I believe it'll be link compatible with 0.1.1 so a simple |
@willholen any idea when the NPM package containing this fix will get published? |
Sorry about the delay! We had some issues with our CI that were only resolved yesterday. The release commit and version bump is already in flight, and is currently in the internal build and regression testing stage. With no other roadblocks, it'll be out today 🤞🤞 (PST). |
And there it is: https://www.npmjs.com/package/hermes-engine/v/0.2.0 |
Awesome, thanks a bunch for coming through @willholen! |
Celebrated too soon. This is the first fully automated release, and it appears that the |
Gotcha, thanks for keeping me in the loop! |
Since RN 0.60.5 still uses the previous name |
## Summary We want to make progress on passing BinSkim for SDL / security best practices. Note: after these changes there are still 3 warnings disabled (4146, 4244 and 4267) that may require additional follow-up.
Duplicating the offline discussion: the Hermes "debug" version is used for RN development and RN debugging, not for debugging Hermes. So, it should be compiled with NDEBUG, to improve performance in the common case.
The text was updated successfully, but these errors were encountered: