Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old DST implementation #1245

Closed
wants to merge 3 commits into from
Closed

Remove old DST implementation #1245

wants to merge 3 commits into from

Conversation

lavenzg
Copy link
Contributor

@lavenzg lavenzg commented Jan 10, 2024

Differential Revision: D52579225

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 10, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52579225

lavenzg added a commit to lavenzg/hermes that referenced this pull request Jan 10, 2024
@lavenzg @facebook-github-bot
Remove old DST implementation (facebook#1245)
5d5bf35 
Summary: Pull Request resolved: facebook#1245

Differential Revision: D52579225
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52579225

lavenzg added a commit to lavenzg/hermes that referenced this pull request Jan 10, 2024
@lavenzg @facebook-github-bot
Remove old DST implementation (facebook#1245)
948aa31 
Summary: Pull Request resolved: facebook#1245

Differential Revision: D52579225
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52579225

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52579225

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52579225

lavenzg added a commit to lavenzg/hermes that referenced this pull request Jan 17, 2024
@lavenzg @facebook-github-bot
Remove old daylightSavingTA() (facebook#1245)
cc108f8 
Summary: Pull Request resolved: facebook#1245

Differential Revision: D52579225
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52579225

lavenzg added a commit to lavenzg/hermes that referenced this pull request Mar 29, 2024
@lavenzg @facebook-github-bot
Remove old daylightSavingTA() (facebook#1245)
20abaeb 
Summary: Pull Request resolved: facebook#1245

Differential Revision: D52579225
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52579225

lavenzg added a commit to lavenzg/hermes that referenced this pull request May 15, 2024
@lavenzg @facebook-github-bot
Remove old daylightSavingTA() (facebook#1245)
3064cc9 
Summary: Pull Request resolved: facebook#1245

Reviewed By: avp

Differential Revision: D52579225
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52579225

lavenzg added a commit to lavenzg/hermes that referenced this pull request May 15, 2024
@lavenzg @facebook-github-bot
Remove old daylightSavingTA() (facebook#1245)
9a943d4 
Summary: Pull Request resolved: facebook#1245

Reviewed By: avp

Differential Revision: D52579225
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52579225

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52579225

lavenzg added a commit to lavenzg/hermes that referenced this pull request Jun 24, 2024
@lavenzg @facebook-github-bot
Remove old daylightSavingTA() (facebook#1245)
d1e5e29 
Summary: Pull Request resolved: facebook#1245

Reviewed By: avp

Differential Revision: D52579225
@lavenzg @facebook-github-bot
Introduce LocalTimeOffsetCache
eed36da 
Summary:
LocalTimeOffsetCache supports caching time zone standard offset and
DST offset for time conversion between UTC and local. The caching
mechanism is mostly the same as V8 (when ICU is not enabled).

Differential Revision: https://www.internalfb.com/diff/D52153598?entry_point=27
@lavenzg @facebook-github-bot
Use LocalTimeOffsetCache for UTC/Local time conversion
c0a3402 
Differential Revision: https://internalfb.com/D52791285
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52579225

lavenzg added a commit to lavenzg/hermes that referenced this pull request Jun 24, 2024
@lavenzg @facebook-github-bot
Remove old daylightSavingTA() (facebook#1245)
7982e0e 
Summary: Pull Request resolved: facebook#1245

Reviewed By: avp

Differential Revision: D52579225
@lavenzg @facebook-github-bot
Remove old daylightSavingTA() (facebook#1245)
da87cfc 
Summary: Pull Request resolved: facebook#1245

Reviewed By: avp

Differential Revision: D52579225
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52579225

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 568a14c.

facebook-github-bot pushed a commit that referenced this pull request Aug 27, 2024
@dannysu @facebook-github-bot
Remove old daylightSavingTA() (#1245) (#1245)
8fb59ab 
Summary:
Pull Request resolved: #1245

Original Author: zhaogang@meta.com
Original Git: 568a14c
Original Reviewed By: avp
Original Revision: D52579225

Reviewed By: lavenzg

Differential Revision: D61574238

fbshipit-source-id: f4208f354d000b5659c52bca08e64772c5dbd33e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lavenzg @facebook-github-bot