New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vfsstream unit tests failing with hhvm #1971
Comments
Thanks for reporting this. Feel free to submit a PR if you (or someone else reading this) gets to this before we do. |
yeah, I would like to, but unfortunately right now you can't run test suite on ubuntu 13.10 :( |
Relates: #1971 Closes #1988 Reviewed By: @JoelMarcey Differential Revision: D1208760 Pulled By: @fredemmott
Is there still an action for us to take here? (The revert happened so you should be able to run the tests at least.) |
Closing this is - we generally work on improving everything listed in the framework test runner, so there's no real action for us to take on this task. If you'd like vfsstream compatibility fixed sooner, the best way is to file separate issues for specific compatibility problems with isolated example code. |
It would be nice to include vfsStream (https://github.com/mikey179/vfsStream , http://vfs.bovigo.org/) library tests in the hhvm parity check.
This is a widely used library for mocking filesystem, very useful for phpunit tests.
How to run the tests:
//get vfsStream
git clone https://github.com/mikey179/vfsStream.git
cd vfsStream
mkdir -p ~/.composer
composer install
//get phpunit
wget https://phar.phpunit.de/phpunit.phar
//run phpunit
hhvm phpunit.phar -c phpunit.xml.dist
current result:
Tests: 328, Assertions: 1135, Failures: 27, Errors: 15, Skipped: 14.
See https://gist.github.com/tmotyl/9326858 for more details
The text was updated successfully, but these errors were encountered: