Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vfsstream unit tests failing with hhvm #1971

Closed
tmotyl opened this issue Mar 3, 2014 · 5 comments
Closed

vfsstream unit tests failing with hhvm #1971

tmotyl opened this issue Mar 3, 2014 · 5 comments

Comments

@tmotyl
Copy link
Contributor

tmotyl commented Mar 3, 2014

It would be nice to include vfsStream (https://github.com/mikey179/vfsStream , http://vfs.bovigo.org/) library tests in the hhvm parity check.
This is a widely used library for mocking filesystem, very useful for phpunit tests.

How to run the tests:
//get vfsStream
git clone https://github.com/mikey179/vfsStream.git
cd vfsStream
mkdir -p ~/.composer
composer install

//get phpunit
wget https://phar.phpunit.de/phpunit.phar

//run phpunit
hhvm phpunit.phar -c phpunit.xml.dist

current result:
Tests: 328, Assertions: 1135, Failures: 27, Errors: 15, Skipped: 14.
See https://gist.github.com/tmotyl/9326858 for more details

@fredemmott
Copy link
Contributor

Thanks for reporting this. Feel free to submit a PR if you (or someone else reading this) gets to this before we do.

@tmotyl
Copy link
Contributor Author

tmotyl commented Mar 4, 2014

yeah, I would like to, but unfortunately right now you can't run test suite on ubuntu 13.10 :(
see #1936

@fredemmott
Copy link
Contributor

We're tracking the Ubuntu issue in #1942 - using #1936 just to track the missing constant. 72ed649 will be backed out shortly, and you should be able to build if you revert that locally.

tmotyl added a commit to tmotyl/hiphop-php that referenced this issue Mar 7, 2014
sgolemon pushed a commit that referenced this issue Mar 8, 2014
Relates: #1971
Closes #1988

Reviewed By: @JoelMarcey

Differential Revision: D1208760

Pulled By: @fredemmott
@scannell
Copy link
Contributor

scannell commented Apr 2, 2014

Is there still an action for us to take here? (The revert happened so you should be able to run the tests at least.)

@fredemmott
Copy link
Contributor

Closing this is - we generally work on improving everything listed in the framework test runner, so there's no real action for us to take on this task. If you'd like vfsstream compatibility fixed sooner, the best way is to file separate issues for specific compatibility problems with isolated example code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants