connection to Postgresql fail to translate host name

[photodude]

HHVM Version

3.16.0-dev (hhvm-nightly)

Standalone code, or other way to reproduce the problem

Joomla Postgresql driver (below is a snip from the driver that hopefully would represent Standalone code)

$dsn .= "host={localhost} ";
$dsn .= "dbname={joomla_ut} user={postgres} password={}";
$this->connection = @pg_connect($dsn)

Expected result

connection to Postgresql without PDOExceptions, previously worked in 3.15 and with the old 3rdparty pgsql module

Actual result

PDOException: [112]: could not translate host name "localhost port=5432 dbname=joomla_ut" to address: Name or service not known

[paulbiss]

cc @simonwelsh

[photodude]

Looks like this maybe an environment configuration issue, I'm going to close this and open an issue with Travis CI. I'll reopen if there is no environment configuration issues

[photodude]

Reopening since I was unable to replicate the issue with similar environment with php 5.6. Seems to be only happening in HHVM.

[simonwelsh]

@photodude are you able to get the raw DSN being used? The code you've pasted is for pg_connect but the error is for PDO.

[photodude]

Yes @simonwelsh I believe this is the raw DSN from the phpunit xml file

<const name="JTEST_DATABASE_POSTGRESQL_DSN" value="host=localhost;port=5432;dbname=joomla_ut;user=postgres;pass=" />

it's parsed by this section of the phpunit setup https://github.com/joomla/joomla-cms/blob/staging/tests/unit/core/case/database/postgresql.php#L35-L107

[photodude]

Maybe the error is from the PDO pgsql portion of phpUnit which is used to set up the tests

$pdo = new PDO($dsn, self::$_options['user'], self::$_options['password']);
return $this->createDefaultDBConnection($pdo, self::$_options['database']);

[simonwelsh]

Ah, it's using spaces instead of semicolons as delimiters. Must've missed that when I switched from a custom DSN parser to the one already in HHVM. Should be easy enough to fix.

[photodude]

We look forward to a patch to fix the DSN parser to allow spaces.

[photodude]

Thanks @simonwelsh @Orvid @aorenste