Assorted Fixes

[Aatch]

This is a bunch of small fixes, mostly to the build system.

• Add vim temporary files to .gitignore (.*.s??)
• Adds a LINK_PAM option to force libpam to be linked. The detection isn't 100% and fails on my machine, however, there does not seem to be a way to detect another way
• Removes the DEEPBIND flag in the call to dlopen for loading extensions. This seems to be the cause of DSO: Possible issue with thread-local data (affecting MemoryManager at least) #1174. At the very least, its removal fixed the issue for me
• Stops CMake from using rpath. This was causing it to relink hhvm before installation, resulting in the systemlib disappearing, breaking make install.
• Adds a link dependency to the target of an embed_systemlib call. It has to be a link dependency, as the custom command is run as a POST_BUILD command, meaning it cannot have dependencies added. This should fix When compiling dynamic extension, <ext.so> is not dependent on <ext.php> #1180.

[Aatch]

Bah, broke it for running tests. Looks like it needs a bit more work to remove rpath usage.

[Aatch]

So it seems that the build system needs more work than I though, so I'm trimming this down.

[scannell]

Can I ask you to take the vim change out also as an artifact of how our merges work? I'm about to commit a superset of that change.

[scannell]

(And, once you've done that: @sgolemon, as the resident cmake expert, can you merge this if it looks good?)

[Aatch]

@scannell done

[scannell]

Thanks. @sgolemon said she would look at it soon.

[sgolemon]

See comments inline on the individual diffs.

[scannell]

@sgolemon, what are we doing with the rest of this?

[sgolemon]

I've been hesitating on this last diff because I don't particularly like the approach of making the user make the decision on linking the library. On the other hand, I haven't had time to come up with something better.

If I don't put something together by tonight, I'll just merge this and go back and make a better fix later.

[sgolemon]

btw... Just for the record, could you paste your c-client/linkage.h file somewhere? I'm curious what your build looks like that it both requires PAM and doesn't declare gss...

[Aatch]

@sgolemon this is my linkage.h file:

extern DRIVER mboxdriver;
extern DRIVER imapdriver;
extern DRIVER nntpdriver;
extern DRIVER pop3driver;
extern DRIVER mixdriver;
extern DRIVER mxdriver;
extern DRIVER mbxdriver;
extern DRIVER tenexdriver;
extern DRIVER mtxdriver;
extern DRIVER mhdriver;
extern DRIVER mmdfdriver;
extern DRIVER unixdriver;
extern DRIVER newsdriver;
extern DRIVER philedriver;
extern DRIVER dummydriver;
extern AUTHENTICATOR auth_ext;
extern AUTHENTICATOR auth_md5;
extern AUTHENTICATOR auth_pla;
extern AUTHENTICATOR auth_log;

Also, your patch causes ext_imap to not compile on my machine due to it (funnily enough) not finding auth_gss.

[kristapsk]

I'm also now having problems with building on Gentoo:

/www/neonz/hhvm/hphp/runtime/ext/ext_imap.cpp: In member function 'virtual void HPHP::imapExtension::moduleInit()': 
/www/neonz/hhvm/hphp/runtime/ext/ext_imap.cpp:181:16: error: 'auth_gss' was not declared in this scope
     auth_link(&auth_gss);     /* link in the gss authenticator */ 
                ^

[kristapsk]

Got ir building. For Gentoo, to have linkage.h auth_gss defined, net-libs/c-client must be rebuilt with kerberos USE flag enabled, which is disabled by default. Unfortunatelly, they have bug in app-crypt/mit-krb5-1.11.2-r1 package, which is dependency for c-client with kerberos, that fails to pull in required Python version for itself. Solution is to unmask app-crypt/mit-krb5-1.11.3 or upgrade python 2.7 by hand (didn't test myself, but should work).

[letharion]

@kristapsk Thank you for posting that back. I was hit by the same issue.