Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define php_ini_scanned_files [closes #3550] #3872

Closed
wants to merge 1 commit into from

Conversation

Majkl578
Copy link
Contributor

Fixes #3550 - undefined php_ini_scanned_files() function.

var_dump(php_ini_scanned_files());

Before:

$ hhvm test.php
Fatal error: Call to undefined function php_ini_scanned_files() in test.php on line 3

After:

$ hhvm test.php 
bool(false)

@facebook-github-bot
Copy link
Contributor

This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D24111

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@SiebelsTim
Copy link
Contributor

When you stub this to always return false, you could do the implementation in php.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Majkl578
Copy link
Contributor Author

@SiebelsTim: Maybe, but when I did that also for php_ini_loaded_file (which is exactly same case), it started crashing, test failure:

FAILED: test/quick/ext_options_php_ini_loaded_file.php
001+ /build/hhvm/hhvm/hphp/util/asm-x64.h:988: void HPHP::jit::X64Assembler::call(HPHP::CodeAddress): assertion `dest && jmpDeltaFits(dest)' failed.
001- bool(false)
002+ Core dumped: Aborted
003+ Aborted

@SiebelsTim
Copy link
Contributor

@Majkl578 Did you remove the HHVM_FE entry?
I had rare issues where doing a clean build helped.

@Majkl578
Copy link
Contributor Author

@SiebelsTim: Yup, removed both HHVM_FUNCTION and HHVM_FE and also __Native. I'll try clean build later (or let Travis do it :) ).

@Majkl578
Copy link
Contributor Author

@SiebelsTim: Looks good on clean build, so amended & force-pushed, thanks for the tip.

Also make php_ini_loaded_file() non-native, since it is just a stub.
@hhvm-bot hhvm-bot closed this in 9fcfbb9 Sep 30, 2014
@Majkl578 Majkl578 deleted the add-php_ini_scanned_files branch October 1, 2014 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

php_ini_scanned_files is not defined
3 participants