New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define php_ini_scanned_files [closes #3550] #3872
Conversation
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D24111 |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
When you stub this to always return false, you could do the implementation in php. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@SiebelsTim: Maybe, but when I did that also for php_ini_loaded_file (which is exactly same case), it started crashing, test failure:
|
@Majkl578 Did you remove the |
@SiebelsTim: Yup, removed both |
f130a36
to
552ddb4
Compare
@SiebelsTim: Looks good on clean build, so amended & force-pushed, thanks for the tip. |
Also make php_ini_loaded_file() non-native, since it is just a stub.
552ddb4
to
a59f1e8
Compare
Fixes #3550 - undefined
php_ini_scanned_files()
function.Before:
After: