Composer gives .ini hints about missing extensions #3177
Conversation
| { | ||
| $paths = array(php_ini_loaded_file()); | ||
|
|
||
| if ($additionalFiles = php_ini_scanned_files()) { |
There was a problem hiding this comment.
php_ini_scanned_files won't work with hhvm yet. facebook/hhvm#3872
There was a problem hiding this comment.
For now, you can use:
if ($additionalFiles = (defined('HHVM_VERSION') ? [] : php_ini_scanned_files())) {
There was a problem hiding this comment.
a false return is a valid return though and more inline how it seems like it will be implemented initially.
|
Thanks @jrobeson and @Majkl578 for spotting HHVM incompatibility. Just pushed updated version. |
|
Great patch. Lack of feedback is a devil with missing extensions. |
|
+1 |
1 similar comment
|
+1 |
|
Hi @Seldaek, I’m just wondering what the status of this PR is. I know you may be very busy but I feel disappointed because I didn’t get a response in almost two years. It would help me to know if there’s anything I could do better here or if it’s not going in ever. Thanks :) |
|
@singles hey, really sorry about the delay merging this :/ It totally escaped me and I haven't had time to go over all open PRs in a long time. Thanks for the work though! It looks better like that and hopefully will help newcomers figure out what's up with extensions. |
Implements feature described in #2756 (no opinions there, so I chose 4th option - one information at the end).