Allow "EXPLAIN..." queries to be recorded properly as well #8139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhvm-bot
reviewed
Mar 20, 2018
There was a problem hiding this comment.
@fredemmott has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Sorry for the slow response; started the internal test run. |
|
test run had infra issues, rescheduled. |
fredemmott
reviewed
Apr 12, 2018
| "(?:explain\\s|describe\\s)?(update|set|show)\\s+([^\\s\\(,]+)|" | ||
| "(?:explain\\s|describe\\s)?(replace).*?\\s+into\\s+([^\\s\\(,]+)|" | ||
| "(?:explain\\s|describe\\s)?(delete).*?\\s+from\\s+([^\\s\\(,]+)|" | ||
| "(?:explain\\s|describe\\s)?(select).*?[\\s`]+from\\s+([^\\s\\(,]+)|" |
There was a problem hiding this comment.
restructure to < 80 columns, then this is good to go; sorry for the delay
Could be a little creative here and add another non-capturing group, but wanted to keep diff small from what had already been reviewed.
|
@demon has updated the pull request. View: changes, changes since last import |
hhvm-bot
approved these changes
Apr 26, 2018
There was a problem hiding this comment.
@fredemmott is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 18, 2019
Summary: Pull Request resolved: facebook/flow#8139 the tests were sending invalid URIs on Windows: `C:\foo\bar` should become `file:///C%3A/foo/bar`, but was `file:///C:\foo\bar`. when decoded, the backslashes are escaped so this becomes a file named "C:\foo\bar" in the root directory. since URIs always use forward slashes, `<PLACEHOLDER_PROJECT_URL_SLASH>` is redundant with `<PLACEHOLDER_PROJECT_URL>/`, so I replaced it. node 10.12 added `url.pathToFileURL` which should do what we want here, but to avoid bumping the required node version, I went with `vscode-uri` instead. Reviewed By: gabelevi, samwgoldman Differential Revision: D18001370 fbshipit-source-id: 15f1cf19c164578ae4747c9c97dc911baeb80bf9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3760 and #3761, EXPLAIN queries are not being properly gathered by the stats collector. Add them as an optional non-capturing part of the query for all CRUD operations.
cc @lavagetto who reported & fixed the original issues referenced.