Update cmake, simplify CXX version handling #8722
Conversation
- We currently manually set the C++ version flags for each compiler, let
CMake do this instead
- That requires updating the minimum CMake version
- that makes the syntax for target_link_libraries slightly stricter; update folly build
- it also makes Apple Clang start being considered it's own thing ('AppleClang' instead of just 'Clang');
opt out of the behavior for now, as we do `if (clang)` a bunch.
Seen a few diffs recently where people can't use some specific part of C++17 - hopefully this fixes it,
as well as making future updates simpler.
I set the cmake minimum version to the minimum version that has CMAKE_CXX_STANDARD in it, which is older
than anything we support, but given that updating that changes cmake's behavior, trying to keep it as small
as possible for this diff.
There was a problem hiding this comment.
@fredemmott has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Hi @fredemmott! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
CMake do this instead
opt out of the behavior for now, as we do
if (clang)a bunch.Seen a few diffs recently where people can't use some specific part of C++17 - hopefully this fixes it,
as well as making future updates simpler.
I set the cmake minimum version to the minimum version that has CMAKE_CXX_STANDARD in it, which is older
than anything we support, but given that updating that changes cmake's behavior, trying to keep it as small
as possible for this diff.