igl | vulkan | Disable dualSrcBlend on Android.

[vinsentli]

Reference from : gpuweb/gpuweb#4283

The dualSrcBlend feature is available on 72.6% of devices. This feature is overwhelmingly supported on Windows, Linux, MacOS and iOS devices, however, only 49.5% of Android devices have support. Android devices that do not support dualSrcBlend primarily use ARM, ImgTec, and Qualcomm GPUs.https://vulkan.gpuinfo.org/listdevicescoverage.php?feature=dualSrcBlend&platform=android&option=not

[rokuz]

Sorry, it looks risky, we don't know how many clients may silently rely on it.
We have the usage of this feature in IGL:

igl/src/igl/vulkan/RenderPipelineState.cpp

Line 250 in 8c591a7

return VK_BLEND_FACTOR_SRC1_COLOR;

Please feel free to keep this fix in your fork, unfortunately we can't accept it in this form IMO. Possibly @mmaurer knows how to do a proper fix in the main branch

[vinsentli]

Another solution is to specify vulkan::VulkanFeatures when calling vulkan::HWDevice::create().

void TinyRenderer::init() {

    igl::vulkan::VulkanFeatures vulkanFeatures(VK_API_VERSION_1_1, config);

    vulkanFeatures.enableDefaultFeatures1_1();
    vulkanFeatures.VkPhysicalDeviceFeatures2_.features.dualSrcBlend = VK_FALSE;

    d = vulkan::HWDevice::create(std::move(ctx),
                                 devices[0],
                                 width_, 
                                 height_, 
                                 0,
                                 nullptr,
                                 &vulkanFeatures,
                                 &result);
}

[rokuz]

That's much better. TinyRenderer is used only for IGL samples

[rokuz]

LGTM

[facebook-github-bot]

@corporateshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@corporateshark merged this pull request in fdc586d.