Skip to content

Commit

Permalink
[tests] delete infer-out before running doli tests
Browse files Browse the repository at this point in the history
Summary:
Otherwise sometimes the test results get polluted with a warning message about
infer-out/ being from a previous infer version. This is because issues.exp is
produced by capturing all console output from infer.

Reviewed By: geralt-encore

Differential Revision: D45903061

fbshipit-source-id: b60c8e306cc2154b7304f0a42e1568083adee2d5
  • Loading branch information
jvillard authored and facebook-github-bot committed May 16, 2023
1 parent 357f622 commit 1c9eab0
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
13 changes: 7 additions & 6 deletions infer/tests/codetoanalyze/sil/doli-capture/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,21 @@ CAPTURE_CMD = $(patsubst %.doli, --capture-doli %.doli, $(SOURCES))

CLEAN_EXTRA = $(CAPTURE_DIR)

issues.exp.test: $(SOURCES) $(INFER_BIN)
$(INFER_BIN) -j 1 --quiet --no-progress-bar -o $(CAPTURE_DIR) $(CAPTURE_CMD) &> $@
issues.exp.test$(TEST_SUFFIX): $(SOURCES) $(INFER_BIN)
$(QUIET)$(REMOVE_DIR) $(CAPTURE_DIR)
$(QUIET)$(INFER_BIN) -j 1 --quiet --no-progress-bar -o $(CAPTURE_DIR) $(CAPTURE_CMD) &> $@

.PHONY: compile
compile: issues.exp.test
compile: issues.exp.test$(TEST_SUFFIX)

.PHONY: test
test: issues.exp.test
test: issues.exp.test$(TEST_SUFFIX)
$(QUIET)cd $(TESTS_DIR) && \
$(call check_no_diff,$(TEST_REL_DIR)/issues.exp$(TEST_RESULT_SUFFIX),$(TEST_REL_DIR)/issues.exp.test$(TEST_SUFFIX))

.PHONY: replace
replace: issues.exp.test
cp $< issues.exp
replace: issues.exp.test$(TEST_SUFFIX)
cp $< issues.exp$(TEST_RESULT_SUFFIX)

.PHONY: clean
clean:
Expand Down
7 changes: 4 additions & 3 deletions infer/tests/codetoanalyze/sil/doli-parsing/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,13 @@ analyze:
print:

.PHONY: test
test: issues.exp.test
test: issues.exp.test$(TEST_SUFFIX)
$(QUIET)cd $(TESTS_DIR) && \
$(call check_no_diff,$(TEST_REL_DIR)/issues.exp$(TEST_RESULT_SUFFIX),$(TEST_REL_DIR)/issues.exp.test$(TEST_SUFFIX))

issues.exp.test: $(SOURCES) $(INFER_BIN)
@for f in $(SOURCES); do $(INFER_BIN) --parse-doli $${f}; done >& $@
issues.exp.test$(TEST_SUFFIX): $(SOURCES) $(INFER_BIN)
$(QUIET)$(REMOVE_DIR) $(INFER_OUT)
@for f in $(SOURCES); do $(INFER_BIN) -o $(INFER_OUT) --parse-doli $${f}; done >& $@

.PHONY: replace
replace: issues.exp.test
Expand Down

0 comments on commit 1c9eab0

Please sign in to comment.