Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[clang] fix evaluation order bug discovered by building with OCaml 4.…
…05.0 Summary: The behaviour of infer was observed to be different in 4.04.2 vs (4.05.0 or 4.04.2+flambda). Investigating further, the behaviour is also different in byte vs native versions of infer under 4.04.2. Looking at the Changelog of 4.05.0 (thanks mbouaziz), there are fixes for inconsistent behaviours between byte and native relative to evaluation order. Lots of debugging later, this 1 line patch is born. Also use `List.concat_map` instead of re-implementing it. Reviewed By: jberdine Differential Revision: D5793809 fbshipit-source-id: 374fb4c
- Loading branch information
5b3c2c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmid here is Jules' fix we talked about on Friday