Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Display preview logo #166

Closed
pestevez opened this issue Mar 12, 2021 · 0 comments · Fixed by #173
Closed

Display preview logo #166

pestevez opened this issue Mar 12, 2021 · 0 comments · Fixed by #173

Comments

@pestevez
Copy link
Contributor

With #162, the tool is showing the preview using data:text/html;charset=utf-8,${encodeURIComponent(contentHtml)} (Source).

With this change, we lost the ability to show the preview design logo, since it was using a relative address:

<amp-img src="preview-logo.png" width="206" height="44"></amp-img>

We should look for a way to keep the data:text/html optimization and to keep the logo. One simple way would be to return from the preview webserver an image that contains the full URL where it is available.

Before

image

After

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant