Allow watch plugin to be configured #6603
Conversation
|
Yeeeeees! ❤️ |
| › Press p to filter by a filename regex pattern. | ||
| › Press t to filter by a test name regex pattern. | ||
| › Press q to quit watch mode. | ||
| › Press k to configured prompt. |
There was a problem hiding this comment.
reads weird, but doesn't matter 🙂
There was a problem hiding this comment.
Good point, let me change it to Press k to filter with a custom prompt
|
Single test failing on CI. |
| @@ -148,3 +148,35 @@ class MyWatchPlugin { | |||
| } | |||
| } | |||
| ``` | |||
|
|
|||
| ## Customization | |||
There was a problem hiding this comment.
@SimenB I added it under the version-23.0 is this OK? Should I add it under a new different version folder instead? Given that it is not present in 23.0
There was a problem hiding this comment.
Yeah, it should be in the master docs here: https://github.com/facebook/jest/blob/master/docs/WatchPlugins.md
Codecov Report
@@ Coverage Diff @@
## master #6603 +/- ##
==========================================
- Coverage 63.73% 63.72% -0.01%
==========================================
Files 235 235
Lines 8931 8933 +2
Branches 4 3 -1
==========================================
+ Hits 5692 5693 +1
- Misses 3238 3239 +1
Partials 1 1
Continue to review full report at Codecov.
|
|
I moved the docs and fixed the linting errors in it |
|
Thanks! |
|
@rickhanlonii the silent reporter makes out slow tests time out due to no output :P Do you think we could print e.g |
|
@mjesun this is good to go, just timeouts on CI |
This Pull Request renovates the package group "jest monorepo". - [jest-environment-node](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0` - [jest](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0` # Release Notes <details> <summary>facebook/jest</summary> ### [`v23.3.0`](https://github.com/facebook/jest/blob/master/CHANGELOG.md#​2330) [Compare Source](jestjs/jest@v23.2.0...v23.3.0) ##### Features - `[jest-cli]` Allow watch plugin to be configured ([#​6603](`jestjs/jest#6603)) - `[jest-snapshot]` Introduce `toMatchInlineSnapshot` and `toThrowErrorMatchingInlineSnapshot` matchers ([#​6380](`jestjs/jest#6380)) ##### Fixes - `[jest-regex-util]` Improve handling already escaped path separators on Windows ([#​6523](`jestjs/jest#6523)) - `[jest-cli]` Fix `testNamePattern` value with interactive snapshots ([#​6579](`jestjs/jest#6579)) - `[jest-cli]` Fix enter to interrupt watch mode ([#​6601](`jestjs/jest#6601)) ##### Chore & Maintenance - `[website]` Switch domain to https://jestjs.io ([#​6549](`jestjs/jest#6549)) - `[tests]` Improve stability of `yarn test` on Windows ([#​6534](`jestjs/jest#6534)) - `[*]` Transpile object shorthand into Node 4 compatible syntax ([#​6582](`jestjs/jest#6582)) - `[*]` Update all legacy links to jestjs.io ([#​6622](`jestjs/jest#6622)) - `[docs]` Add docs for 23.1, 23.2, and 23.3 ([#​6623](`jestjs/jest#6623)) - `[website]` Only test/deploy website if relevant files are changed ([#​6626](`jestjs/jest#6626)) - `[docs]` Describe behavior of `resetModules` option when set to `false` ([#​6641](`jestjs/jest#6641)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This should make it enable plugins to customize their
keysand also allow for custom behavior within plugins, for example, the usage ofglobsinjest-watch-typeaheadRelates to jest-community/jest-watch-typeahead#9 and jest-community/jest-watch-typeahead#10
I'm not sure if something else needs to be updated in the config parsing. cc: @thymikee
Test plan