Keep so-called "scoping functions" on same line as assignment #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: See examples in tests. Note that the Google style version has a problem, because it has equal continuation and block indents. One solution would be to emit conditional blocks, after we create them :) (google/google-java-format#556) Reviewed By: hick209 Differential Revision: D25738228 fbshipit-source-id: 98cbc5f622eccde635f07d5cecd9c93d40d6fd97
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D25738228 |
|
This pull request has been merged in 6c7dd8d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See examples in tests.
Note that the Google style version has a problem, because it has equal continuation and block indents. One solution would be to emit conditional blocks, after we create them :) (google/google-java-format#556)
Reviewed By: hick209
Differential Revision: D25738228