Allow optional break after string-literals #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
nreid260
commented
Apr 14, 2023
| @@ -68,7 +68,7 @@ fun assertFormatted( | |||
|
|
|||
| fun assertThatFormatting(code: String): FormattedCodeSubject { | |||
| fun codes(): Subject.Factory<FormattedCodeSubject, String> { | |||
| return Subject.Factory { metadata, subject -> FormattedCodeSubject(metadata, subject) } | |||
| return Subject.Factory { metadata, subject -> FormattedCodeSubject(metadata, subject!!) } | |||
There was a problem hiding this comment.
The API of Subject.Factory is changing (has changed within Google) so that the subject is nullable even if the constructor doesn't accept null.
|
@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hick209
reviewed
Apr 18, 2023
Co-authored-by: Nivaldo Bondança <hick209@gmail.com>
|
@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.