Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: selection changes to null when selecting text after node selection on mobile devices #3098

Closed
ibastawisi opened this issue Oct 2, 2022 · 2 comments · Fixed by #4395
Closed

Bug: selection changes to null when selecting text after node selection on mobile devices #3098

ibastawisi opened this issue Oct 2, 2022 · 2 comments · Fixed by #4395
Assignees
@trueadm

Comments

@ibastawisi
Copy link
Contributor

ibastawisi commented Oct 2, 2022 •
edited
Loading

Lexical version: 0.5.0

Desktop.2022.10.02.-.17.54.19.02.mp4

@trueadm trueadm self-assigned this Nov 23, 2022
@trueadm
Copy link
Collaborator

trueadm commented Jan 3, 2023

This is actually to be expected on touch devices. Moving from node selection to range selection will require an extra touch. Whilst we can force the adjusted behavior, it leads to strange bugs when you try and do things like drag and drop + resizing. So for those reasons, closing for now as I don't see this as too big an issue.

@trueadm trueadm closed this as completed Jan 3, 2023
@ibastawisi
Copy link
Contributor Author

This is actually to be expected on touch devices. Moving from node selection to range selection will require an extra touch. Whilst we can force the adjusted behavior, it leads to strange bugs when you try and do things like drag and drop + resizing. So for those reasons, closing for now as I don't see this as too big an issue.

Hi there!
I was wondering if this could be fixed, it was working as expected before this commit 382766a
can you review it?

ibastawisi added a commit to ibastawisi/lexical that referenced this issue Apr 24, 2023
@ibastawisi
Fix text click selection on touch devices facebook#3098
12d1804
@ibastawisi ibastawisi mentioned this issue Apr 24, 2023
Merged
zurfyx pushed a commit that referenced this issue May 1, 2023
@ibastawisi
Fix text click selection on touch devices #3098 (#4395)
970fba2
vyductan added a commit to vyductan/lexical-forked that referenced this issue May 1, 2023
@vyductan
Merge pull request #1 from facebook/main
d96e3b5 
Fix text click selection on touch devices facebook#3098 (facebook#4395)
This was referenced May 23, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trueadm trueadm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix text click selection on touch devices #3098 ibastawisi/lexical
3 participants
@trueadm @thegreatercurve @ibastawisi