Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text click selection on touch devices #3098 #4395

Merged
merged 1 commit into from
May 1, 2023
Merged

Fix text click selection on touch devices #3098 #4395

merged 1 commit into from
May 1, 2023

Conversation

ibastawisi
Copy link
Contributor

This PR fixes #3098

@vercel
Copy link

vercel bot commented Apr 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 1:42am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 1:42am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2023
zurfyx
zurfyx reviewed Apr 24, 2023
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, can you expand on why a click solution vs selectionchange?

@ibastawisi
Copy link
Contributor Author

Thank you, can you expand on why a click solution vs selectionchange?

I don't know the exact cause of this, but inside the selectionchange event handler the value of domSelection.anchorNode is null, however in onClick it is not. This happens only with touch event, with mouse it is as expected.

touch-selection-debug.mp4

zurfyx
zurfyx approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, while I'm not too sure this addresses the root cause let's merge this for now as it addressed an immediate issue

@zurfyx zurfyx merged commit 970fba2 into facebook:main May 1, 2023
@zurfyx zurfyx mentioned this pull request May 1, 2023
Merged
1 task
@zurfyx
Copy link
Member

zurfyx commented May 1, 2023

Correction: the click handler is likely the best place given that the similar pointerdown code will not see selection (selection.anchor === null)

vyductan added a commit to vyductan/lexical-forked that referenced this pull request May 1, 2023
@vyductan
Merge pull request #1 from facebook/main
d96e3b5 
Fix text click selection on touch devices facebook#3098 (facebook#4395)
This was referenced May 23, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: selection changes to null when selecting text after node selection on mobile devices
3 participants
@ibastawisi @zurfyx @facebook-github-bot