Add missing usages of $applyNodeReplacement
#3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
thegreatercurve
changed the title
thegreatercurve
force-pushed
the
bug/missing-apply-node-replacements
branch
from
cb82b06
to
30ef5a8
Compare
thegreatercurve
force-pushed
the
bug/missing-apply-node-replacements
branch
from
30ef5a8
to
eaa5f54
Compare
thegreatercurve
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson and
tylerjbainbridge
as code owners
thegreatercurve
changed the title
$applyNodeReplacement
thegreatercurve
force-pushed
the
bug/missing-apply-node-replacements
branch
from
a2d1a1f
to
9d7c62d
Compare
trueadm
approved these changes
Dec 19, 2022
acywatson
requested changes
Dec 19, 2022
There was a problem hiding this comment.
Generally you don't need to add $applyNodeReplacement to your subclasses unless you plan to expose them as a library, which I think is probably rare in userland. I would say let's not put this in every creator on the playground for people to just copy and paste everywhere. The problem this is solving is allowing customization of core node behavior without changing the core library itself. The concept is not necessarily useful or applicable in places like TweetNode, where we don't even expose the node.
thegreatercurve
force-pushed
the
bug/missing-apply-node-replacements
branch
from
9d7c62d
to
6ad12e4
Compare
|
@acywatson Fair point. I've just added it in to the exported nodes now. |
acywatson
approved these changes
Dec 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.