simplify logic for the fix "Improve responsiveness of the floating text format toolbar buttons" #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlessioGr
requested review from
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, #4298 fixed the problem where button clicks in the floating toolbar did not react if the mouse was moving.
I actually came up with a different solution, where it simply checks if the mouse is over the floating toolbar element.
It's less code and does not require a mouseDownListener - thus I think it might improve readability + performance.
Do let me know what you think, or if the previous solution is better!
ALSO: I'm currently not home and only have my laptop trackpad to test - no mouse! Please test this out with a mouse to make sure this PR does not reduce the responsiveness compared to the previous solution!