Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify logic for the fix "Improve responsiveness of the floating text format toolbar buttons" #4431

Merged
merged 1 commit into from
May 1, 2023
Merged

simplify logic for the fix "Improve responsiveness of the floating text format toolbar buttons" #4431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions packages/lexical-playground/src/plugins/FloatingTextFormatToolbarPlugin/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,44 +67,37 @@ function TextFormatFloatingToolbar({
editor.dispatchCommand(INSERT_INLINE_COMMAND, undefined);
};

const movementThreshold = 5; // Set a threshold for minimum movement in pixels

let initialPosition = {x: 0, y: 0};

function mouseDownListener(e: MouseEvent) {
initialPosition = {x: e.clientX, y: e.clientY};
}

function mouseMoveListener(e: MouseEvent) {
if (
popupCharStylesEditorRef?.current &&
(e.buttons === 1 || e.buttons === 3)
) {
const distanceMoved = Math.sqrt(
Math.pow(e.clientX - initialPosition.x, 2) +
Math.pow(e.clientY - initialPosition.y, 2),
);

if (distanceMoved > movementThreshold) {
popupCharStylesEditorRef.current.style.pointerEvents = 'none';
if (popupCharStylesEditorRef.current.style.pointerEvents !== 'none') {
const x = e.clientX;
const y = e.clientY;
const elementUnderMouse = document.elementFromPoint(x, y);

if (!popupCharStylesEditorRef.current.contains(elementUnderMouse)) {
// Mouse is not over the target element => not a normal click, but probably a drag
popupCharStylesEditorRef.current.style.pointerEvents = 'none';
}
}
}
}

function mouseUpListener(e: MouseEvent) {
if (popupCharStylesEditorRef?.current) {
popupCharStylesEditorRef.current.style.pointerEvents = 'auto';
if (popupCharStylesEditorRef.current.style.pointerEvents !== 'auto') {
popupCharStylesEditorRef.current.style.pointerEvents = 'auto';
}
}
}

useEffect(() => {
if (popupCharStylesEditorRef?.current) {
document.addEventListener('mousedown', mouseDownListener);
document.addEventListener('mousemove', mouseMoveListener);
document.addEventListener('mouseup', mouseUpListener);

return () => {
document.removeEventListener('mousedown', mouseDownListener);
document.removeEventListener('mousemove', mouseMoveListener);
document.removeEventListener('mouseup', mouseUpListener);
};
Expand Down