Fix GC memory leak #4510
Merged
Fix GC memory leak #4510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurfyx
requested review from
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
fantactuka
approved these changes
May 17, 2023
fantactuka
reviewed
May 17, 2023
packages/lexical/src/LexicalGC.ts
Outdated
| @@ -47,6 +47,7 @@ function $garbageCollectDetachedDeepChildNodes( | |||
| let child = node.getFirstChild(); | |||
|
|
|||
| while (child !== null) { | |||
| const nextChild = child.getNextSibling(); | |||
| const childKey = child.__key; | |||
| if (child !== undefined && child.__parent === parentKey) { | |||
There was a problem hiding this comment.
Not related to PR changes, but wondering why would we have undefined check here, it would throw one line above when accessing __key, and we have null check in while loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we introduced a memory leak on the GC module when we launched doubly linked lists.
The root cause is that now order is important
$garbageCollectDetachedDeepChildNodeswas not correct. It will never be true because the parent is not attached in the first place.Fixes #4509