Fix GC memory leak (2) #4513
Merged
Fix GC memory leak (2) #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurfyx
requested review from
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
fantactuka
reviewed
May 18, 2023
packages/lexical/src/LexicalGC.ts
Outdated
Comment on lines
112
to
115
| const nodeMapDeleteLength = nodeMapDelete.length; | ||
| for (let i = 0; i < nodeMapDeleteLength; i++) { | ||
| nodeMap.delete(nodeMapDelete[i]); | ||
| } |
There was a problem hiding this comment.
IIRC, for .. of is cooler 😎
There was a problem hiding this comment.
@fantactuka - Is it also faster for arrays? afaik we started using for..of as a replacement for Array.from(<iterable = Set|Map)
fantactuka
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardcoded condition on the test (
const node = $getNodeByKey('1');) was hiding that the fix in #4510 was actually not good enough.Subtrees fail. For example, if a subtree is deleted and we visit the parent later, their children might not have deleted (previously deleted)
This PR stores the dirtyElements keys to delete and does the deletion later, without interfering with the loop itself.