Link title is correctly applied through the command #5191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petyosi
requested review from
zurfyx,
fantactuka,
acywatson and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
zurfyx
approved these changes
Nov 2, 2023
| await editor.update(() => { | ||
| $selectAll(); | ||
| toggleLink('https://lexical.dev/', {title: 'Lexical Website'}); | ||
| // editor?.dispatchCommand(TOGGLE_LINK_COMMAND, {url: 'https://lexical.dev/', title: 'Lexical Website'}) |
There was a problem hiding this comment.
Remove or did you want to do something with it?
There was a problem hiding this comment.
Removing. That's how I wanted to test, but it would pull React, so I abandoned the idea.
ivailop7
approved these changes
Nov 2, 2023
ivailop7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATM, the TOGGLE_LINK_COMMAND ignores the title in the payload. It's a one liner fix, but I wanted to ensure that it works as expected so an illustrative test is included.
Thanks!