[lexical-website] Bug Fix: add allow-popups-to-escape-sandbox to iframe sandbox flags #5988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs so "Fork on StackBlitz" works
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
potatowagon
approved these changes
Apr 30, 2024
| @@ -28,5 +28,5 @@ Once this is done, Lexical will replace all ParagraphNode instances with CustomP | |||
| style="width:100%; height:700px; border:0; border-radius:4px; overflow:hidden;" | |||
| title="lexical-collapsible-container-plugin-example" | |||
| allow="accelerometer; ambient-light-sensor; camera; encrypted-media; geolocation; gyroscope; hid; microphone; midi; payment; usb; vr; xr-spatial-tracking" | |||
| sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" | |||
| sandbox="allow-forms allow-modals allow-popups allow-popups-to-escape-sandbox allow-presentation allow-same-origin allow-scripts" | |||
There was a problem hiding this comment.
cool didnt know about this flag
There was a problem hiding this comment.
Me either, until I saw someone run into the bug on discord and then followed the trail 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When playing with the examples on the website, clicking the "Fork on StackBlitz" button previously opened a blocked popup. With this sandbox flag, the popup loads without being blocked by cross-origin-opener-policy. Can reproduce with Chrome, Firefox and Safari on mac.
Test plan
Before
After