-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-website] Bug Fix: add allow-popups-to-escape-sandbox to iframe sandbox flags #5988
[lexical-website] Bug Fix: add allow-popups-to-escape-sandbox to iframe sandbox flags #5988
Conversation
…gs so "Fork on StackBlitz" works
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -28,5 +28,5 @@ Once this is done, Lexical will replace all ParagraphNode instances with CustomP | |||
style="width:100%; height:700px; border:0; border-radius:4px; overflow:hidden;" | |||
title="lexical-collapsible-container-plugin-example" | |||
allow="accelerometer; ambient-light-sensor; camera; encrypted-media; geolocation; gyroscope; hid; microphone; midi; payment; usb; vr; xr-spatial-tracking" | |||
sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" | |||
sandbox="allow-forms allow-modals allow-popups allow-popups-to-escape-sandbox allow-presentation allow-same-origin allow-scripts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool didnt know about this flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me either, until I saw someone run into the bug on discord and then followed the trail 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Description
When playing with the examples on the website, clicking the "Fork on StackBlitz" button previously opened a blocked popup. With this sandbox flag, the popup loads without being blocked by cross-origin-opener-policy. Can reproduce with Chrome, Firefox and Safari on mac.
Test plan
Before
After