Dont sync empty files #6004
Closed
Dont sync empty files #6004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acywatson
requested review from
zurfyx,
fantactuka,
Fetz and
ivailop7
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
StyleT
approved these changes
May 1, 2024
size-limit report 📦
|
|
The latest commit in #5999 should address this, it ensures there's always at least one statement in the code before handing it over to hermes and then it undoes that workaround before writing it to disk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow files that contain only comments are copied over as empty. This is a problem for our internal linters. I couldn't figure out how to make this work in rewriteImports because I don't understand the hermes-transform API, but we can ignore empty files and that should prevent this issue.