[build] Chore: Upgrade rollup and vite to latest versions

[etrepum]

Description

rollup and vite have not been upgraded in some time, it makes sense to keep them up to date

Packages upgraded:

• rollup (and all plugins)
• vite (and all plugins)
• eslint (and all plugins) - but only up to 8
  • Switched from flowtype to ft-flow due to change in fb preset.
  • Switched from deprecated babel-eslint to @babel/eslint-parser
• docusaurus

I also upgraded most of the workflow actions because I was getting a spurious cache failure. I did not update to actions/upload-artifact@v4 which seemed like it might need some other config changes https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

Other changes:

• Lint fixes for the new eslint-plugin-simple-import-sort heuristics
• playground's setupEnv.ts was getting tree shaken in prod because it was only performing side-effects so I refactored it and the settings panel which didn't really work correctly previously
• playground now loads the dev (vercel, most tests) or prod (specific e2e tests) version of lexical from built artifacts rather than directly compiling the typescript (except when in serve mode, e.g. npm run start, so you can use hmr while developing locally)

Closes: #6012

Test plan

Before

Builds work and pass all tests

After

Builds still work and still pass all the tests

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 4, 2024 4:34am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 4, 2024 4:34am

[ivailop7]

Thank you for doing this!

[potatowagon]

great work thankyou for this upgrade!

[zurfyx]

@ivailop7 @zurfyx one thing I noticed is that we were not currently deploying the prod build to the playground (probably after the esm refactor), but I just restored that behavior here. We were using a module resolution strategy that pointed vite directly to the typescript source files instead of the build products in dist.

I think maybe we should consider using the dev build of lexical on vercel, since it's much friendlier (in particular with regard to the tree view command history and potential error messages) and leave the prod verification to CI tasks… what do you all think? (RE #2460)

Thank you for doing this Bob! I think that's reasonable, the point of the prod build since we first introduced in the CI has always been to have some degree of certainty on a build that is slightly different than dev. We had some issues in the past with the rollup bundling that we didn't catch until it broke in prod. Currently, I think that the CI step that runs all E2E on prod already gives us this confidence so we can move on with your proposal.

[zurfyx]

I noticed that the port is 5173 now, I wonder how hard it is to make port 3000 back, no strong opinions though. Merging now to avoid the rebase churn.

[zurfyx]

I assume this is an unrelated cleanup

[etrepum]

Yes, this was supposed to be deleted in #5876

[zurfyx]

Suggested change

	let paragraphKey: string;
	let paragraphKey: NodeKey;

[etrepum]

honestly I only did it this way because there's a plethora of other tests that use string for keys, might be a good lint for us to find variables named /[Kk]ey$/ with a string type!

[zurfyx]

So much better, finding the suffix was always time-consuming