Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[playground] Bug Fix: change default dev port to 3000 #6026

Merged
merged 1 commit into from
May 4, 2024

Conversation

etrepum
Copy link
Contributor

@etrepum etrepum commented May 4, 2024

Description

npm run dev (and associated npm run start) used to start on port 3000, which was the old vite default. The default changed to 5173, but no reason we can't keep the previous behavior #6018 (review)

Test plan

Before

npm run dev listens on port 5173 (after #6018 was merged)

After

  • npm run dev listens on port 3000
  • tests and other commands that also specify a port still get the desired choice

Copy link

vercel bot commented May 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2024 6:13pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2024 6:13pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 4, 2024
@ivailop7
Copy link
Collaborator

ivailop7 commented May 4, 2024

Does it make sense to put the port in the vite config file, rather than extend the npm scripts. I think it's cleaner, no strong opinion on this. Approved.

Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for quick follow-up!

@etrepum
Copy link
Contributor Author

etrepum commented May 4, 2024

@ivailop7 I also don't have a strong opinion about it either way. server: {port: 3000} in the vite.config.ts does that. If you specify multiple ports on the command line it takes the last one, so practically speaking other than where the setting is it's not a very observable difference. We manually specify the port elsewhere in the package.json files so I just did it in the same place.

@ivailop7
Copy link
Collaborator

ivailop7 commented May 4, 2024

@ivailop7 I also don't have a strong opinion about it either way. server: {port: 3000} in the vite.config.ts does that. If you specify multiple ports on the command line it takes the last one, so practically speaking other than where the setting is it's not a very observable difference. We manually specify the port elsewhere in the package.json files so I just did it in the same place.

Fair enough

@ivailop7 ivailop7 merged commit 72347ca into facebook:main May 4, 2024
46 checks passed
@etrepum etrepum deleted the playground-port-3000 branch May 11, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants