[CI] Refactor: clean up github workflows for cache correctness #6029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
commented
May 5, 2024
| @@ -127,7 +127,7 @@ export default defineConfig({ | |||
| find: 'lexicalOriginal', | |||
| replacement: path.resolve('../lexical/src/index.ts'), | |||
| }, | |||
| ...moduleResolution('preview'), | |||
| ...moduleResolution('source'), | |||
There was a problem hiding this comment.
I don't know how this didn't get caught by the integrity check before it was merged?
etrepum
changed the title
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
etrepum
commented
May 5, 2024
| # Run daily at 2:30am UTC | ||
| # - cron: '30 2 * * 1-5' | ||
| # remove the workflow_dispatch when this is turned on | ||
| workflow_dispatch |
There was a problem hiding this comment.
I did this so I would stop getting emails about it on every push
etrepum
commented
May 5, 2024
| * yaml package.json configuration, because we need to override the resolution | ||
| * of modules to ensure we are pulling in monorepo build products as | ||
| * dependencies rather than trying to use something stale from node_modules. | ||
| */ | ||
| const glob = require('glob'); | ||
| const path = require('node:path'); | ||
| const fs = require('fs-extra'); |
There was a problem hiding this comment.
I noticed this unused import and typo when I was auditing the workflows
ivailop7
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a lot of test workflow. The workflows could get in various states where the cache was poisoned.
The cache correctness related changes:
cache: npmoption which also considers the node version, and should in theory do the right thing (the actions/cache docs recommend to not cache node_modules as we were doing)npm ci. Maybe a little slower than caching node_modules, takes about 30s, but the global artifacts should be cached and we have a postinstall action to run for wxt with the lexical-devtools package which was the cause of some of the problems.Test plan
Before
Sometimes get strange build failures due to poisoned cache (hard to intentionally repro)
After